feat: use a job scheduler to launch workflows when the system is healthy (SBP-421)#96
Merged
Conversation
vtnphan
requested changes
Jul 7, 2026
vtnphan
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making this big job! I've tested for 4 runs and got them working now. Got few comments regarding the job details for query job using seqera_run_id, and the bulk-prediction workflow missing
vtnphan
approved these changes
Jul 8, 2026
vtnphan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me now, tested locally. I think we should have a docs where to see workflow submission error/debugging as we can't see the error log from UI anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-421 move workflow launches to the job scheduler, so that:
As part of this, some refactors have been needed:
How to Test
Run
uv run pytest- large change touching a lot of the code, but I have tried to keep/update unit tests wherever possibleType of change
Checklist