Conversation
vtnphan
marked this pull request as ready for review
July 16, 2026 00:37
marius-mather
requested changes
Jul 16, 2026
marius-mather
left a comment
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
looks good, just a few comments/questions
marius-mather
approved these changes
Jul 16, 2026
marius-mather
left a comment
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
looking good now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-481 Reworks Gadi cluster options for bindflow/proteinfold/wisps to use a
-A email[:base64(ip)]account string, makes the Gadi project configurable viaGADI_PROJECT, and fixes the scheduler not loading.env.Changes
cluster_utils.py:encode_ip()+GADI_PROJECT(env, defaults"yz52").get_*_config_text()now takesemail/ip_addressinstead ofjob_id/user_details/timestamp; callers updated.GADI_PROJECTinstead of hardcoded"yz52".run_scheduler.pynow callsload_dotenv(), soSEQERA_API_URLetc. are picked up when run standalone.How to Test
uv sync --all-extrasuv run pytest tests/test_services_cluster_utils.py tests/test_services_bindflow_config.py tests/test_proteinfold_coverage.py tests/test_wisps_coverage.py -vuv run python -m app.run_scheduler— no longer errors on missingSEQERA_API_URL.Type of change
Checklist