fix: preserve user-defined data_* properties on data_file nodes#67
Merged
Merged
Conversation
construct_props unconditionally overwrote data_category, data_format, data_type and core_metadata_collections for any data_file node, silently discarding enum values a user had declared in input.yaml. Switch to setdefault so the hardcoded placeholders only apply when the user has not already defined the property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
construct_propsinsrc/gen3schemadev/converter.pyunconditionally overwrotedata_category,data_format,data_type, andcore_metadata_collectionson anydata_filenode, silently discarding enum values a user had declared ininput.yaml.dict[key] =todict.setdefault(key, ...)so the hardcoded placeholders only apply when the user has not already defined the property.tests/test_converter.pyplus a new fixturetests/input_example_file_props.ymlcovering: preservation of each of the three reported properties, preservation ofcore_metadata_collections, the default-injection fallback path, and an end-to-endpopulate_templateround-trip.Test plan
poetry run python3 -m pytest tests/test_converter.py -v— 32/32 passpoetry run python3 -m pytest tests/— full suite 99/99 pass