Skip to content

Refactor: remove organism_grouping_key from schema#19

Merged
emilylm merged 5 commits into
mainfrom
remove-organism-grouping-key
Apr 30, 2026
Merged

Refactor: remove organism_grouping_key from schema#19
emilylm merged 5 commits into
mainfrom
remove-organism-grouping-key

Conversation

@emilylm

@emilylm emilylm commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

📌 Summary


Remove organism.grouping_key from the database schema and use taxon_id instead, to reflect changes to the data mapper's output. taxon_id is a natural choice for PK on organism table, since it is unique and must exist for all organisms.

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Refactor (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • ⚙️ CI / build / tooling change

🧩 Key Changes

  • Updates db schema to 1) remove grouping_key from organism table and make taxon_id the PK and 2) update any FK references to the organism table to reference taxon_id
  • Update the codebase to reflect these changes

✅ Checklist

  • Tests are passing locally / in CI
  • New tests have been added for new or changed functionality
  • Self-review completed
  • Documentation updated (if needed)
  • No sensitive data or secrets included

🔍 Review Notes


📎 Related Issues / Tickets


@emilylm
emilylm merged commit ab0edbe into main Apr 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant