Skip to content

feat: update response from broker endpoints#14

Merged
emilylm merged 6 commits into
mainfrom
fix-broker-claim-endpoint
Mar 6, 2026
Merged

feat: update response from broker endpoints#14
emilylm merged 6 commits into
mainfrom
fix-broker-claim-endpoint

Conversation

@emilylm

@emilylm emilylm commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Summary

This PR fixes broker ID handling so responses and report payloads consistently distinguish entity IDs from submission IDs.


🔄 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Refactor (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • ⚙️ CI / build / tooling change

🧩 Key Changes

  • Broker endpoints now return canonical entity IDs in ClaimedEntity.id and submission IDs in ClaimedEntity.submission_id.
  • Broker report processing now accepts explicit submission_id (with backward-compatible fallback to id) and validates entity/submission mismatches with 409.

✅ Checklist

  • Tests are passing locally / in CI
  • New tests have been added for new or changed functionality
  • Self-review completed
  • Documentation updated (if needed)
  • No sensitive data or secrets included

🔍 Review Notes


📎 Related Issues / Tickets

  • Closes #
  • Related to #

@emilylm
emilylm merged commit f50a38a into main Mar 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant