Update assembly data types#12
Merged
Merged
Conversation
…y/intent endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR introduces an assembly intent/reservation flow so manifest generation can reserve a version without prematurely creating an
assemblyrecord, and hardens error handling for invalid experiment/platform combinations.The goal is to avoid long-running pipeline race conditions (duplicate provisional versions) while preserving strict
assemblyschema requirements for final assembly creation.🔄 Type of Change
🧩 Key Changes
assembly_runreservation model/table (+ migration) to persist manifest intent state and reserve version numbers safely before final assembly creation.POST /api/v1/assemblies/intent/{tax_id}to reserve version + return manifest; updatedGET /api/v1/assemblies/manifest/{tax_id}to requiresample_idand return the latest (or requested) reserved manifest.tol_idon assembly creation/schema/model and includedtolid+versionin generated manifest output./api/v1/assemblies/optimal-sample/{tax_id}). Logic is TBD - on hold whilst requirements are being fleshed out.ValueErrorfrom data-type detection is now mapped toAppErrorwith unified error envelope (instead of 500).✅ Checklist
🔍 Review Notes
assembly_runlifecycle and version reservation logic (assemblymax version +assembly_runmax version).GET /assemblies/manifest/{tax_id}now requiressample_idPOST /assemblies/intent/{tax_id}is the reservation entrypointCREATE TABLE IF NOT EXISTS/DROP TABLE IF EXISTS; please confirm this is acceptable for your migration policy.📎 Related Issues / Tickets