Skip to content

Form validation#19

Open
vtnphan wants to merge 16 commits into
mainfrom
form-validation
Open

Form validation#19
vtnphan wants to merge 16 commits into
mainfrom
form-validation

Conversation

@vtnphan

@vtnphan vtnphan commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

Hi @marius-mather , this might be my last commit, not pretty sure i can follow your changes request later, but this enhancement is quite important for this platform.

This PR introduces several enhancements to the workflow launch form, related issue(#8)

  1. Support for input parameter types
  • Added support for type-safe inputs: string, number, email, file path, and regex pattern
  • Applied appropriate field-level validation using react-hook-form and Controller
  1. Step 3 (Review & Launch) validation
  • Implemented field validation logic in the review step (ParamsSummary)
  • Validation rules now apply consistently across all steps of the wizard (e.g., required fields, pattern matching)
  1. Default value injection from schema
  • Automatically sets default values for each parameter using the values defined in the nextflow_schema.json
  • Improves UX by reducing the need for user input when defaults are already suitable

Notes: This branch is created from results branch, hasn't been rebased yet :((
Please see below screen recording for more details

Screen.Recording.2025-08-01.at.2.08.02.pm.mov

@vtnphan vtnphan requested a review from marius-mather August 1, 2025 04:18
@marius-mather

Copy link
Copy Markdown
Collaborator

Thanks @laclac102 ! I'm not sure I have time to review this this afternoon, so thanks for all your great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants