test: add zero cliff period tests for forge-vesting — closes #80#346
Open
spiffamani wants to merge 1 commit intoAustinaminu2:mainfrom
Open
test: add zero cliff period tests for forge-vesting — closes #80#346spiffamani wants to merge 1 commit intoAustinaminu2:mainfrom
spiffamani wants to merge 1 commit intoAustinaminu2:mainfrom
Conversation
…nu2#80) - Fix setup_with_token() to use stellar_asset.address() correctly - Fix balance checks to use token::Client instead of StellarAssetClient - Fix cancel tests to use setup_with_token() for real token transfers - Add 6 zero cliff tests: - test_zero_cliff_initialize_succeeds - test_zero_cliff_claim_succeeds_immediately - test_zero_cliff_correct_vested_amount_at_halfway - test_zero_cliff_fully_vested_after_duration - test_zero_cliff_claim_immediately_after_initialize - test_zero_cliff_vesting_starts_immediately
Author
|
please check and merge my job all my test passed, base on the job you recomended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for
forge-vestingwithcliff_seconds = 0, closing issue #80.Changes
setup_with_token()to correctly extractAddressfromStellarAssetContracttoken::Clientinstead ofStellarAssetClientsetup_with_token()for real token transfersZero Cliff Tests Added
test_zero_cliff_initialize_succeeds— cliff=0 is valid configtest_zero_cliff_claim_succeeds_immediately— claim works after 100s with no clifftest_zero_cliff_correct_vested_amount_at_halfway— 500_000 vested at t=500test_zero_cliff_fully_vested_after_duration— fully vested at t=2000test_zero_cliff_claim_immediately_after_initialize— NothingToClaim at t=0test_zero_cliff_vesting_starts_immediately— 1_000 vested at t=1Test Results
Checklist
cargo test -p forge-vesting— 19/19 passing