basic ecommerce thing #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw56578
reviewed
Jan 25, 2018
|
|
||
| var starMarkup = ''; | ||
| for (var i = 0, j = props.product.rating; i < j; i++) { | ||
| starMarkup += '★'; |
Contributor
There was a problem hiding this comment.
Make note of what markup actually made the star images show up. jsx allows you to manipulate html elements as javascript also. so you could have done something like
myarray.push(<span/>)
jw56578
reviewed
Jan 25, 2018
| import React from "react"; | ||
| import ProductDetail from './ProductDetail'; | ||
|
|
||
| function ProductGrid(props){ |
Contributor
There was a problem hiding this comment.
Good job organizing things into another component. This probably makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.