Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Use the project's root dir to run reek #151

Closed
wants to merge 1 commit into from

Conversation

arielj
Copy link

@arielj arielj commented Oct 9, 2020

This PR fixes this issue #149

Currently, the plugin uses the current file's dir, but that breaks the rules directories rules defined at the .reek.yml config file suggested for Rails projects:

directories:
  "app/controllers":
    IrresponsibleModule:
      enabled: false
    NestedIterators:
      max_allowed_nesting: 2
    UnusedPrivateMethod:
      enabled: false
    InstanceVariableAssumption:
      enabled: false
  "app/helpers":
    IrresponsibleModule:
      enabled: false
    UtilityFunction:
      enabled: false
  "app/mailers":
    InstanceVariableAssumption:
      enabled: false
  "app/models":
    InstanceVariableAssumption:
      enabled: false

Using the project's root path instead helps reek find directories that matches those config values.

@arielj
Copy link
Author

arielj commented Oct 9, 2020

@Arcanemagus a review is greatly appreciated, thanks

@arielj
Copy link
Author

arielj commented Dec 13, 2022

Closing this PR since this seems to be abandoned and atom will be sunsetted

@arielj arielj closed this Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant