-
Notifications
You must be signed in to change notification settings - Fork 298
update java and go dependencies to their latest releases #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Henry Avetisyan <[email protected]>
Summary of ChangesHello @havetisyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to modernize the project's dependency stack by upgrading both its Go runtime and a comprehensive set of Go and Java libraries to their most recent stable releases. This proactive update ensures the application benefits from the latest security fixes, performance enhancements, and new features provided by these updated components, contributing to overall system stability and maintainability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Go and Java dependencies to their latest versions. The Go version is also updated to 1.25.0. The changes are mostly routine dependency bumps. I've added a comment regarding a potential issue with the OpenTelemetry semantic conventions version in the Go code, recommending an update for compatibility with the new OTel library versions.
| go.opentelemetry.io/otel v1.39.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.39.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.39.0 | ||
| go.opentelemetry.io/otel/metric v1.39.0 | ||
| go.opentelemetry.io/otel/sdk v1.39.0 | ||
| go.opentelemetry.io/otel/sdk/metric v1.39.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OpenTelemetry libraries are updated to v1.39.0, but the semantic convention package used in libs/go/sia/otel/metric_sender.go is still v1.37.0. It's best practice to align the semconv version with the OTel library version. Please update the import path in libs/go/sia/otel/metric_sender.go to the corresponding semconv version for v1.39.0 to avoid using deprecated attributes and to adhere to the latest conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ go get go.opentelemetry.io/otel/semconv/v1.39.0
go: module go.opentelemetry.io/otel@upgrade found (v1.39.0), but does not contain package go.opentelemetry.io/otel/semconv/v1.39.0
so we'll stick with 1.37.0 for now in the code
Description
Contribution Checklist:
Attach Screenshots (Optional)