Skip to content

Conversation

@mlajkim
Copy link
Contributor

@mlajkim mlajkim commented May 30, 2025

Background

The current GItHubActionInstanceProvider does not allow multiple GitHub Action environments with one Athenz ZTS Server.

What's done?

Note

The CSV is intended to mean for values that can be separated by commas, rather than using the CSV file format.

Now allows the csv for the enterprise:

athenz.zts.github_actions.enterprise=first-enterprise,second-enterprise

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

@mlajkim mlajkim marked this pull request as draft May 30, 2025 05:52
@mlajkim mlajkim changed the title Feat: allow csv for enterprise Feat: allow csv for enterprise for GitHubActionProvider May 30, 2025
@mlajkim mlajkim changed the title Feat: allow csv for enterprise for GitHubActionProvider Feat: allow csv for enterprise in GitHubActionProvider Jun 2, 2025
@mlajkim mlajkim force-pushed the feat/enable-multiple-enterprises-for-github-action branch 2 times, most recently from be53bb0 to ddc2369 Compare June 2, 2025 04:38
@mlajkim mlajkim changed the title Feat: allow csv for enterprise in GitHubActionProvider Feat: allow csv for enterprise in GitHubActionProvider Jun 5, 2025
@mlajkim mlajkim force-pushed the feat/enable-multiple-enterprises-for-github-action branch from d0893d1 to 9c17976 Compare June 5, 2025 03:21
mlajkim added 3 commits June 5, 2025 12:50
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
@mlajkim mlajkim force-pushed the feat/enable-multiple-enterprises-for-github-action branch from b28a00b to 7690eb2 Compare June 5, 2025 03:50
@mlajkim
Copy link
Contributor Author

mlajkim commented Jul 16, 2025

Closed as #2992 has been selected as a solution for the multiple configurations (environments) feature

@mlajkim mlajkim closed this Jul 16, 2025
@mlajkim mlajkim deleted the feat/enable-multiple-enterprises-for-github-action branch July 16, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant