-
Notifications
You must be signed in to change notification settings - Fork 298
[DNM] [Prototype] GitHub Action with Multiple Configurations using CommonClass
#2975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mlajkim
wants to merge
17
commits into
AthenZ:master
from
mlajkim:prototype/multiple-configurations-for-github-action
Closed
[DNM] [Prototype] GitHub Action with Multiple Configurations using CommonClass
#2975
mlajkim
wants to merge
17
commits into
AthenZ:master
from
mlajkim:prototype/multiple-configurations-for-github-action
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommonClass
6d4724c to
94ccbc6
Compare
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Aaron Jeongwoo Kim <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Bumps [undici](https://github.com/nodejs/undici) from 6.21.1 to 6.21.3. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.21.1...v6.21.3) --- updated-dependencies: - dependency-name: undici dependency-version: 6.21.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Bumps [multer](https://github.com/expressjs/multer) from 1.4.5-lts.1 to 2.0.0. - [Release notes](https://github.com/expressjs/multer/releases) - [Changelog](https://github.com/expressjs/multer/blob/v2.0.0/CHANGELOG.md) - [Commits](expressjs/multer@v1.4.5-lts.1...v2.0.0) --- updated-dependencies: - dependency-name: multer dependency-version: 2.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Henry Avetisyan <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
…do not change (AthenZ#2966) * update modified --------- Signed-off-by: Takuya Matsumoto <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Henry Avetisyan <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Henry Avetisyan <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Henry Avetisyan <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Po-Yao Chen <[email protected]> Co-authored-by: Po-Yao Chen <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Henry Avetisyan <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
Signed-off-by: Henry Avetisyan <[email protected]> Signed-off-by: Jeongwoo Kim - jekim <[email protected]>
36bb50d to
7f337a2
Compare
Contributor
Author
|
Closed as #2992 has been selected as a solution for the multiple configurations (environments) feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The current GItHubActionInstanceProvider does not allow multiple GitHub Action environments with one Athenz ZTS Server.
What's done?
The PR enables you to create your own instance plugin on a separate class as needed with only keys defined:
This way we can create multiple classes with multiple configurations as the following in
zts.properties, without duplicated logic code: