Refactor board and planet queries - #5384
Draft
heisenbugged wants to merge 1 commit into
Draft
Conversation
🔬 Test Results✅ JSON ValidationNo JSON files changed. ❌ Build FailedMaven build failed with no test-failure details captured — see the Actions run for the full log. |
Contributor
|
I like the naming of getRepresentation more than toString, given how sometimes we want to get representation without a ping or fogged/unfogged. |
Contributor
|
This change is also hard to review because so many of the changes are just changing getRepresentation into toString. I dont have time to sift through all of those to find the real stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Common board and planet operations were repeatedly implemented through nested tile, holder, planet, and player loops. This made rules harder to read and encouraged duplicate helper APIs. The new domain-level queries keep rule predicates visible while removing storage-hierarchy boilerplate.
Scope
Combat and combat-replay implementation files and tests are intentionally excluded from this PR. Deprecated compatibility delegates remain temporarily so unchanged combat code continues to compile against the new core APIs.
Validation
mvn testgit diff --check