Skip to content

Refactor transaction item parsing - #5362

Open
heisenbugged wants to merge 1 commit into
masterfrom
codex/refactor-transaction-items
Open

Refactor transaction item parsing#5362
heisenbugged wants to merge 1 commit into
masterfrom
codex/refactor-transaction-items

Conversation

@heisenbugged

Copy link
Copy Markdown
Collaborator

Summary

  • Add a small TransactionItem value object for the existing stored transaction item format.
  • Use it for transaction matching, clearing, display, public event sanitizing, and trade offer rendering.
  • Keep saved transaction item serialization exactly unchanged.

Test Plan

  • mvn -Dtest=ti4.service.transaction.TransactionItemTest,ti4.helpers.TransactionHelperTest test

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

🔬 Test Results

✅ JSON Validation

No JSON files changed.


✅ Formatting Checks Passed

All files pass Spotless formatting.


✅ JUnit Tests Passed

All tests passed successfully.

@heisenbugged
heisenbugged force-pushed the codex/refactor-transaction-items branch from 42de3d0 to f3aa6b8 Compare July 7, 2026 21:12
@Fingon00

Copy link
Copy Markdown
Contributor

I find the flow of this much harder to parse/work with. It will make it more difficult to debug/fix/add to transactions in the future as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants