Skip to content

Merge latest master and resolve MessageListener conflict without regressing whisper refactor - #5174

Open
jamesrudolph with Copilot wants to merge 6 commits into
masterfrom
copilot/move-whisper-methods
Open

Merge latest master and resolve MessageListener conflict without regressing whisper refactor#5174
jamesrudolph with Copilot wants to merge 6 commits into
masterfrom
copilot/move-whisper-methods

Conversation

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces a significant refactor and enhancement of the "whisper" and "remind me" command handling in the Discord bot, moving legacy message-based whisper handling into explicit slash commands and centralizing logic. It also adds new commands for whispering and reminders, improves option auto-completion, and cleans up unused code.

New Features and Slash Commands:

  • Added new slash commands: /whisper, /w (alias for whisper), and /remind_me for sending private or future-dated messages between players, or reminders to oneself. (WhisperCommand.java, WCommand.java, RemindMeCommand.java, SlashCommandManager.java) [1] [2] [3] [4] [5]
  • Introduced WhisperCommandBase to encapsulate shared logic for whisper commands, supporting options for target player, message, and future delivery.

Refactoring and Centralization:

  • Moved all legacy message-based whisper handling logic from MessageListener into WhisperService, removing a large block of parsing and processing code from the listener. Now, MessageListener delegates whisper handling to WhisperService.handleWhispers. [1] [2] [3]
  • Cleaned up unused imports and regex patterns from MessageListener.java. [1] [2] [3]

Improvements to Option Handling and Auto-complete:

  • Added a new constant TO and updated auto-complete logic to support the /whisper command’s recipient field. [1] [2]

These changes modernize whisper interactions, make them more robust and user-friendly, and lay groundwork for future extensibility.

Copilot AI and others added 2 commits June 1, 2026 01:52
Co-authored-by: jamesrudolph <39609802+jamesrudolph@users.noreply.github.com>
Co-authored-by: jamesrudolph <39609802+jamesrudolph@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

🔬 Test Results

✅ JSON Validation

No JSON files changed.


✅ Formatting Checks Passed

All files pass Spotless formatting.


✅ JUnit Tests Passed

All tests passed successfully.

@jamesrudolph
jamesrudolph marked this pull request as ready for review June 16, 2026 20:05
Co-authored-by: jamesrudolph <39609802+jamesrudolph@users.noreply.github.com>
Copilot AI changed the title Refactor whisper handling into WhisperService and add /whisper, /w, and /remind_me commands Merge latest master and resolve MessageListener conflict without regressing whisper refactor Jun 27, 2026
Copilot AI requested a review from jamesrudolph June 27, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants