Open
Use JDA's LRU MemberCachePolicy instead of caching everything at startup#5006
Conversation
Agent-Logs-Url: https://github.com/AsyncTI4/TI4_map_generator_bot/sessions/65c67648-7b2c-4d4e-abf6-ecebc305d9cd Co-authored-by: wholton <3317595+wholton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AsyncTI4/TI4_map_generator_bot/sessions/65c67648-7b2c-4d4e-abf6-ecebc305d9cd Co-authored-by: wholton <3317595+wholton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AsyncTI4/TI4_map_generator_bot/sessions/cef36229-3f45-40b3-a16d-80fa4766d9a1 Co-authored-by: wholton <3317595+wholton@users.noreply.github.com>
…eRestAction Agent-Logs-Url: https://github.com/AsyncTI4/TI4_map_generator_bot/sessions/69fe1720-7147-43af-a1de-682a046531de Co-authored-by: wholton <3317595+wholton@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wholton
May 8, 2026 07:13
View session
wholton
marked this pull request as ready for review
May 8, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDA already provides
MemberCachePolicy.lru(n)and cache-awareCacheRestActionretrieval — no need to layer a custom Caffeine cache on top, or manually pre-check the JDA cache before callingretrieve*.Changes
MemberCachePolicy.lru(20_000)replacesMemberCachePolicy.ALL— JDA manages a bounded LRU eviction cache natively, capping memory without unbounded growthgetMemberById/getUserById— removed manualgetMemberById()/getUserById()pre-checks;retrieveMemberById()andretrieveUserById()returnCacheRestActionwhich already hits the cache before making a REST call