-
Notifications
You must be signed in to change notification settings - Fork 2
fix(ui): defer default-open tool details #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
726f028
fix(ui): defer default-open tool details
Astro-Han 1a61831
test(ui): cover deferred tool detail mounting
Astro-Han 248b77b
fix(ui): keep animated deferred details through close
Astro-Han a4e6cce
test(app): add heavy bash perf probe
Astro-Han 2dcc23e
test(app): keep perf profile unit out of playwright
Astro-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { expect, test } from "bun:test" | ||
| import { basicToolInitialReady } from "./basic-tool" | ||
|
|
||
| test("deferred default-open tools do not mount details immediately", () => { | ||
| expect(basicToolInitialReady({ defaultOpen: true, defer: true })).toBe(false) | ||
| }) | ||
|
|
||
| test("non-deferred default-open tools keep the previous immediate details behavior", () => { | ||
| expect(basicToolInitialReady({ defaultOpen: true })).toBe(true) | ||
| expect(basicToolInitialReady({ defaultOpen: true, defer: false })).toBe(true) | ||
| }) | ||
|
|
||
| test("closed tools start without mounted details", () => { | ||
| expect(basicToolInitialReady({ defaultOpen: false, defer: true })).toBe(false) | ||
| expect(basicToolInitialReady({ defaultOpen: false })).toBe(false) | ||
| expect(basicToolInitialReady({ defer: true })).toBe(false) | ||
| expect(basicToolInitialReady({})).toBe(false) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.