fix(app): restore project rename entry and harden sidebar against nested interactives#544
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces context menu support for project headers in the sidebar, allowing users to rename or remove projects via right-click. It refactors the sidebar implementation by extracting the ProjectGroupHeader component and updates the corresponding E2E tests and internationalization files for English and Chinese. Additionally, a new test suite was added to enforce an invariant against nesting interactive controls within the sidebar. I have no feedback to provide.
Summary
Restore the PawWork sidebar project rename/remove entry points and harden the sidebar against nested interactive controls.
This PR:
ProjectGroupHeadercomponent.Why
Task #18 reported that the installed app could not rename a left-sidebar workspace/project and that the rename dialog looked wrong.
RCA found two regressions from PR #517 / commit
def93393c:DropdownMenu.Trigger as={IconButton}inside the collapse<button>, creating invalid button-inside-button DOM. Desktop WebView event/focus handling made the project menu entry unreliable.en.tsandzh.ts, so the dialog/menu copy could show raw keys if the entry point opened.Related Issue
Task #18.
Human Review Status
Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.
Review Focus
ProjectGroupHeaderstructure: the group toggle and project menu trigger must remain siblings, not nested controls.Risk Notes
Low-to-medium UI risk. The behavior change is scoped to project group headers in the PawWork sidebar. Session row and workspace row behavior are intentionally untouched. The remove action remains hide-from-sidebar, not file deletion.
No dependency, permission, packaging, migration, or generated-file changes.
How To Verify
Screenshots or Recordings
Installed-app reproduction screenshots were uploaded in Slock thread
#PawWork:2c7f3674:c8e7a5e8-0deb-467e-95f8-24e044d01a6079bff17a-2f7e-4f02-8400-85c5142e64b9121cb679-c80a-4f3a-845b-a29cc16e71daThe focused E2E also captures the project header, opened menu, rename dialog, and post-rename state as Playwright artifacts.
Checklist
dev, and my PR title and commit messages use Conventional Commits in English