Skip to content

test(opencode): avoid Windows Node exit teardown in built harnesses #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 5 commits into from
May 7, 2026
+94 −13
Merged

test(opencode): avoid Windows Node exit teardown in built harnesses #499

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
580534b
test(opencode): avoid fetch teardown in built server bootstrap
Astro-Han May 7, 2026
bdac89a
test(opencode): close built webfetch harness connections
Astro-Han May 7, 2026
e845e0d
test(opencode): avoid global fetch in built webfetch harness
Astro-Han May 7, 2026
86d3559
test(opencode): simplify built bootstrap harness request calls
Astro-Han May 7, 2026
bc2434f
test(opencode): normalize webfetch harness init headers
Astro-Han May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions packages/opencode/test/server/built-node-skill-bootstrap.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ describe("built node server skill bootstrap", () => {
expectModelsSnapshotUnchanged(modelsFixture)

const script = `
import { request as httpRequest } from "node:http"
import { Server, Log } from ${JSON.stringify(pathToFileURL(distEntry).href)}

const password = process.env.OPENCODE_SERVER_PASSWORD
Expand All @@ -61,19 +62,37 @@ describe("built node server skill bootstrap", () => {
const listener = await Server.listen({ port: 0, hostname: "127.0.0.1" })
const auth = "Basic " + Buffer.from(\`opencode:\${password}\`).toString("base64")

const request = async (pathname) => {
// This test exits the child process explicitly. On Windows Node 24, fetch
// can abort during process.exit() handle teardown and hide the bootstrap result.
const request = (pathname) => new Promise((resolve, reject) => {
const url = new URL(pathname, listener.url)
url.searchParams.set("directory", directory)
const response = await fetch(url, {
headers: {
authorization: auth,

const req = httpRequest(
url,
{
agent: false,
headers: {
authorization: auth,
connection: "close",
},
},
})
return {
status: response.status,
body: await response.text(),
}
}
(response) => {
const chunks = []
response.on("data", (chunk) => chunks.push(chunk))
response.on("error", reject)
response.on("end", () => {
resolve({
status: response.statusCode ?? 0,
body: Buffer.concat(chunks).toString("utf8"),
})
})
},
)

req.on("error", reject)
req.end()
})

let exitCode = 0
try {
Expand Down
59 changes: 56 additions & 3 deletions packages/opencode/test/server/built-node-webfetch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ describe("built node webfetch", () => {

const script = `
import http from "node:http"
import https from "node:https"
import { Effect } from "effect"
import { FetchHttpClient } from "effect/unstable/http"
import { Instance, Log, ToolRegistry } from ${JSON.stringify(pathToFileURL(distEntry).href)}

if (typeof HTMLRewriter !== "undefined") {
Expand Down Expand Up @@ -82,8 +84,52 @@ describe("built node webfetch", () => {
const rawOpenHTML = \`<body>\${"<".repeat(50_000)}\`
const whitespaceHTML = \`<body>\${"\\r".repeat(50_000)}visible text</body>\`

// The test validates the built Node WebFetch parser path. Avoid Node
// 24 Windows global fetch teardown, which can abort during process.exit().
const nodeFetch = (input, init = {}) => new Promise((resolve, reject) => {
const url = new URL(input instanceof Request ? input.url : input)
const client = url.protocol === "https:" ? https : http
const headers = { ...(input instanceof Request ? Object.fromEntries(input.headers) : {}), ...(init.headers ?? {}) }
const req = client.request(
url,
{
method: init.method ?? (input instanceof Request ? input.method : "GET"),
headers: { ...headers, connection: "close" },
agent: false,
signal: init.signal,
},
(res) => {
const chunks = []
res.on("data", (chunk) => chunks.push(chunk))
res.on("error", reject)
res.on("end", () => {
const responseHeaders = new Headers()
for (const [key, value] of Object.entries(res.headers)) {
if (Array.isArray(value)) {
for (const item of value) responseHeaders.append(key, item)
} else if (value !== undefined) {
responseHeaders.set(key, value)
}
}
resolve(
new Response(Buffer.concat(chunks), {
status: res.statusCode ?? 200,
statusText: res.statusMessage,
headers: responseHeaders,
}),
)
})
},
)

req.on("error", reject)
if (init.signal?.aborted) req.destroy(init.signal.reason)
req.end(init.body)
})

const sockets = new Set()
const server = http.createServer((req, res) => {
res.writeHead(200, { "content-type": "text/html; charset=utf-8" })
res.writeHead(200, { "content-type": "text/html; charset=utf-8", connection: "close" })
res.end(
req.url === "/hostile.html"
? hostileHTML
Expand All @@ -92,7 +138,11 @@ describe("built node webfetch", () => {
: req.url === "/whitespace.html"
? whitespaceHTML
: happyHTML,
)
)
})
server.on("connection", (socket) => {
sockets.add(socket)
socket.on("close", () => sockets.delete(socket))
})

await new Promise((resolve) => server.listen(0, "127.0.0.1", resolve))
Expand Down Expand Up @@ -123,7 +173,7 @@ describe("built node webfetch", () => {
metadata: () => Effect.void,
ask: () => Effect.void,
},
),
).pipe(Effect.provideService(FetchHttpClient.Fetch, nodeFetch)),
)

const happy = await run("/page.html")
Expand All @@ -147,8 +197,11 @@ describe("built node webfetch", () => {

console.log(JSON.stringify(output))
} finally {
await Instance.disposeAll()
await new Promise((resolve, reject) => {
server.close((error) => (error ? reject(error) : resolve()))
server.closeAllConnections?.()
for (const socket of sockets) socket.destroy()
})
}

Expand Down
Loading