fix(deps): resolve esbuild audit advisory#1281
Conversation
📝 WalkthroughWalkthroughThis PR adds an explicit ChangesDependency version override
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds esbuild version 0.28.1 as a direct dependency in package.json and updates the lockfile accordingly. It also cleans up older, nested versions of esbuild (such as those from drizzle-kit and electron-vite) from the lockfile. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 117: package.json is pinned to "esbuild": "0.28.1" but old esbuild@0.27.x
entries remain in bun.lock files; add an npm "overrides" (or "resolutions" if
you prefer) section to package.json that forces esbuild and its platform
packages to 0.28.1+ (e.g., add "overrides": { "esbuild": "0.28.1", "`@esbuild/`*":
"0.28.1" }), then run bun install to regenerate bun.lock and site/bun.lock and
commit the updated lockfiles so all `@esbuild/`* entries resolve to 0.28.1+.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 94d75cf7-e8e1-43d2-a904-0b0905dde1bd
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
package.json
Summary
Adds root and site
esbuildoverrides to resolve GHSA-gv7w-rqvm-qjhr and unblock dependency audit coverage. It also teaches PR labeler to route root dependency updates (package.json,bun.lock) to theciarea, which fixes thepr-triagefailure this dependency-only PR exposed. There is no related issue; this PR responds to the live CI audit failure affecting open PRs.Why
bun audit --audit-level=highstarted failing after GitHub published GHSA-gv7w-rqvm-qjhr foresbuild >=0.17.0 <0.28.1. The existing root lockfile resolvedesbuild@0.27.7plus nested0.25.12copies through Vite, electron-vite, and drizzle-kit.The site is a separate Bun project and also carried vulnerable
esbuild@0.27.7resolutions through Astro/Vite, so this PR applies the same override there and refreshessite/bun.lock.The first PR run also showed a label-policy gap:
actions/labelerusessync-labels: true, so manually addingciis removed unless the changed paths match.github/labeler.yml. Root dependency updates did not match any primary routing label before this PR.Related Issue
None.
Human Review Status
Pending
Review Focus
Check that the dependency overrides are limited to
esbuild@0.28.1, both lockfiles no longer carry vulnerableesbuildresolutions, and root dependency updates are routed tociby labeler.Risk Notes
The dependency override affects build tooling used by Vite, electron-vite, drizzle-kit, and the Astro site. Local app, desktop, and site builds passed with the override; PR CI covers the broader OS matrix. The labeler change is limited to root
package.jsonandbun.lockupdates. No visible UI or copy changed, so no screenshot was taken.How To Verify
Screenshots or Recordings
Not applicable; no visible UI or copy changes.
Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.Summary by CodeRabbit