-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi label models #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonjininfo
reviewed
Sep 11, 2024
308c18a
to
df54a2c
Compare
paluchasz
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some nits here and there
Removed subspan logic as unused removed SmartSpanFinder in place of MultilabelSpanFinder
…l classification models. TokenizedWordProcessor added to constructor sig removed labels, detect_subspans and threshold as are now obsolete/handled by TokenizedWordProcessor HFDataset now takes keys_to_use arg to determine which tensors to return from BatchEncodings
…moved obsolete multilabel.yaml
…instead of their proper name
Co-authored-by: Szymon Palucha <[email protected]>
07f265a
to
b65fc0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reworked a bunch of logic to clean up TransformersModelForTokenClassificationNerStep ahead of multilabel token classification. Removed some dead code for obsolete concepts.
See commit comments for specific changes