feat(metrics): mark desktop installation source - #164
Merged
Conversation
Soulter
force-pushed
the
codex/installation-source-metrics
branch
from
August 6, 2026 08:44
f13a77c to
f39978d
Compare
Soulter
marked this pull request as ready for review
August 6, 2026 13:56
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider whether
mark_as_desktop_managedshould respect a pre-existingASTRBOT_INSTALLATION_SOURCEenv value (e.g., only set it if not already present) to allow explicit overrides in more complex launch scenarios.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider whether `mark_as_desktop_managed` should respect a pre-existing `ASTRBOT_INSTALLATION_SOURCE` env value (e.g., only set it if not already present) to allow explicit overrides in more complex launch scenarios.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASTRBOT_INSTALLATION_SOURCE=desktopwhen launching the packaged AstrBot backend.Why
AstrBot's anonymous metrics need a stable installation-source marker so desktop launches can be distinguished from other installation methods.
Impact
Packaged desktop launches now identify their installation source as
desktop; existing desktop management markers remain unchanged.Validation
cargo fmt --manifest-path src-tauri/Cargo.toml -- --checkcargo test --manifest-path src-tauri/Cargo.toml mark_as_desktop_managed_sets_desktop_management_markersSummary by Sourcery
Mark packaged desktop backend launches with a stable installation-source environment variable for metrics.
New Features:
Documentation:
Tests: