Update to Ubuntu Touch 20.04 focal #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The changes look good to me but do I understand correctly that this PR as-is wouldn't build because it contains a mix of qmake and cmake ? :/ Specifically, https://github.com/AsteroidOS/telescope/blob/master/telescope.pro#L5 would break because of the submodule update. |
Author
|
You can obviously cherry-pick the patch on top of the qmake branch and then it will work |
Author
|
I have tried to migrate everything to cmake. However, this change have still some raw edges. Also I am not very comfortable with git modules. I will appreciate if someone else will finish that effort. My main interest is still in Amazfish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made changes according to https://docs.ubports.com/es/latest/appdev/guides/port-to-focal.html and telescope seems to be working.
Closes: #63
the git submodule should be updated according to that pull request.
AsteroidOS/asteroidsyncservice#58