Skip to content

Move composer auth to secret#16

Open
odrais-amsicorp wants to merge 3 commits intomasterfrom
move-composer-auth-to-secret
Open

Move composer auth to secret#16
odrais-amsicorp wants to merge 3 commits intomasterfrom
move-composer-auth-to-secret

Conversation

@odrais-amsicorp
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Composer authentication configuration by moving the GitHub OAuth token from an inline JSON definition to a dedicated secret. The change simplifies the workflow by using a single COMPOSER_AUTH secret that can be managed centrally rather than constructing authentication JSON inline.

Key changes:

  • Added COMPOSER_AUTH as an optional secret input to the reusable workflow
  • Replaced inline COMPOSER_AUTH environment variable with a direct file write from the secret
  • Maintained existing Magento repository authentication configuration

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
workflow-templates/magento-package.yml Adds COMPOSER_AUTH to the list of secrets passed to the reusable workflow
.github/workflows/magento-package.yml Defines COMPOSER_AUTH as optional input and replaces inline JSON construction with direct secret usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants