Update fn_weaponShopMags to get all available Ammo #627
Conversation
The current version is a hotfix I suggested a while ago. As I just realized, bohemia changed several config entries, so I came up with a way to cover all "muzzles" (all underbarrel weapons) and as using the magazineWell entries, I'm now able to adress all crossover ammo from other mods etc. I'm about to test it asap.
There was a problem hiding this comment.
Hi @Blauschimmel, thanks for the PR, please could you update your PR to the current standards of the framework, we seem to have gone backwards in some areas such as usage of private, and counting arrays instead of checking for blank etc. Also the framework utilises 4 spaces instead of tabs, hence why it failed validation.
|
@DomT602 What do you mean by checking for blank and no usage of private? I didn't work on Altis Life for quite a while now so what am I missing out? |
Hi @Blauschimmel, if you look at what was there previously you can see the usage of private as a Keyword (negligble performance impact) compared to the old style array. We were also moving away from |
|
For file styling - try to look for an editor config-plugin for your text editor. That way you don't have to bother about spaces instead of tabs and stuff like that, cause the repo includes an editor config file |
4 participants
Didn't make an issue yet, but as you guys can see, this is a rework of that file, now also inculding all muzzles, meaning that all kinds of shotguns and grenade launchers, even from other modpack are included now. Tested and working!
Resolves #.
Changes proposed in this pull request:
I have tested my changes and corrected any errors found