fix: stub isReadOnly on ACP queued-tools test mock - #2
Merged
AryanNandanwar merged 1 commit intoAug 17, 2026
Merged
Conversation
Timeline capture now calls toolManager.isReadOnly() during tool execution. The queued-tools spec mock omitted that method, so four tests failed in CI with "isReadOnly is not a function".
AryanNandanwar
marked this pull request as ready for review
August 17, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Unit Tests & Coverage Analysis failure on Nano-Collective/nanocoder#887.
Timeline capture in
runAcpConversationnow callstoolManager.isReadOnly()before executing a tool. Theacp-queued-toolsspec mock did not implement that method, so four tests rejected with:TypeError: toolManager.isReadOnly is not a functionrunAcpConversation - abort marks announced-but-unrun calls failedrunAcpConversation - an announced call is never sent as tool_call twicerunAcpConversation - a single tool call is still announced as tool_callrunAcpConversation - the queued announcement carries no contentThe mock now matches
acp-conversation.spec.ts:write_fileandexecute_bashare treated as mutating; everything else is read-only.Merge this into
agent-action-timeline-undoto re-run CI on Nano-Collective#887.Type of Change
Changeset
Testing
Automated Tests
source/acp/acp-queued-tools.spec.tstests now passacp-conversation,acp-timeline,acp-agent) — 82 testspnpm test:allcompletes successfully)Manual Testing
Checklist