Skip to content

Commit

Permalink
Ignore application overrides when reading the SE base of an RSE.
Browse files Browse the repository at this point in the history
This is consistent with the behavior when saving RSEs and simplifies the
reasoning about application overrides for derived classes.
  • Loading branch information
LTLA committed Oct 16, 2024
1 parent 6244b11 commit d37271c
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions R/readRangedSummarizedExperiment.R
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,12 @@
#' @importFrom SummarizedExperiment SummarizedExperiment rowData rowData<- rowRanges<-
#' @import alabaster.base
readRangedSummarizedExperiment <- function(path, metadata, ...) {
metadata$type <- "summarized_experiment"
se <- altReadObject(path, metadata=metadata, ...)
# We don't try to respect application overrides when loading the base
# instance. Application developers should just pretend that we copied the
# code from readSummarizedExperiment, rather than trying to inject in
# custom code at this point, which gets too complicated - see the
# associated commentary for saveObject,SummarizedExperiment-method.
se <- readSummarizedExperiment(path, metadata=metadata, ...)

rrdir <- file.path(path, "row_ranges")
if (file.exists(rrdir)) {
Expand Down

0 comments on commit d37271c

Please sign in to comment.