Skip to content

Conversation

@uo294039
Copy link

@uo294039 uo294039 commented May 3, 2025

No description provided.

@uo294039 uo294039 self-assigned this May 3, 2025
@uo294039 uo294039 added the documentation 📝 Improvements or additions to documentation label May 3, 2025
Copy link

@MiguelAlvarezHernandez MiguelAlvarezHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the first diagram is missing the game module explanation and I do not get the point of the Auth API, also in our application autentication is splitted in two but I am not sure if here should be displayed
image

In the second diagram I am not getting the point of that external APIs (only wikidata and llm are external APIs)
image

Copy link

@Y4vra Y4vra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game service should be part of the system in the diagrams, and the auth service uses the mongodb database. Also, write how the game service both saves games and provides the user's statistics.


* **Wichat Application Proxy: **
When interacting with the server, a <TO BE DEFINED> proxy will be tasked with redirecting the queries to the petitions to the Wichat application client, which will also be deployed on a <TO BE DEFINED> web server.
When interacting with the server, a <TO BE DEFINED> proxy will be tasked with redirecting the queries to the petitions to the Wichat application client, which will also be deployed on a Azure web server.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nginx proxy is used

Copy link

@MiguelAlvarezHernandez MiguelAlvarezHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The line of the right is not correct, the user module should be in.

Also in the technical context I guess the question generator is mentioned because of the wikiData api, but if so I dont get why the llm is not mentioned as is an external service that is used in the app (shown in the image)

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2025

Copy link

@Y4vra Y4vra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent

@Y4vra Y4vra merged commit 0f35e9f into master May 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📝 Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants