Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life improvements #86

Merged
merged 35 commits into from
Nov 29, 2023
Merged

Quality of life improvements #86

merged 35 commits into from
Nov 29, 2023

Conversation

AroneyS
Copy link
Owner

@AroneyS AroneyS commented Nov 23, 2023

Handle env variables better

  • Rename aviary-gtdbtk-dir and aviary-checkm2-dir to *-db
  • Add database env variables to ibis build (SingleM, CheckM2, GTDBtk)
  • Delete build folder on build start
  • Ibis build example indicate that argument is for conda env folder
  • Add TMPDIR env variable to ibis build (defaults to /tmp)
  • Pass TMPDIR env variable to Aviary
  • Add aviary build to ibis build? - --skip-long-reads
  • Load from env variables if arg not provided
  • Pass conda env path to Aviary

No genomes updates

  • Add --no-genomes to ibis update
  • Add schema to no_genomes.py csv loading
  • Notify if any samples from pipe are empty?

Minimise standard workflow arguments

  • Load samples and genomes from config if not provided to ibis iterate
  • Check standard aviary output location if aviary outputs and new genomes not provided to ibis iterate
  • Create cumulative skip_coassemblies input that is loaded by iterate
  • Check standard sample SingleM dir if not provided to ibis iterate
  • Check standard read_size file if not provided to ibis iterate
  • Remove --no-genomes argument and set if arg not provided
  • Update warning ibis.py line 763
  • Update iterate examples in help and README
  • Set max size to 50Gbp unless single-assembly

Bump major version due to breaking changes

  • --coassemble-output now refers to --output dir from coassemble command instead of referring to the coassemble subfolder within that output dir
  • Removed --no-genomes argument and made that the default
  • Rename --aviary-[gtdbtk, checkm2]-dir args to --aviary-[gtdbtk, checkm2]-db

@AroneyS AroneyS merged commit ace595e into master Nov 29, 2023
1 check passed
@AroneyS AroneyS deleted the quality-of-life branch November 29, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant