-
Notifications
You must be signed in to change notification settings - Fork 168
fix(smolagents): give agent run span as more descriptive span name #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
...ference-instrumentation-smolagents/src/openinference/instrumentation/smolagents/_wrappers.py
Outdated
Show resolved
Hide resolved
...ference-instrumentation-smolagents/src/openinference/instrumentation/smolagents/_wrappers.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
hey @Zoe14 , thanks for the PR. There is a simple formatting step you need to run to get your PR over the line - run |
Contributor
Author
|
can we merge this ? @caroger |
caroger
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having generic CodeAgent / ToolCallingAgent, now the log would show which specific agent
Note
Set run span name to the agent's
nameif present, otherwise fall back to the class name.Written by Cursor Bugbot for commit 60e7f99. This will update automatically on new commits. Configure here.