feat: Add removeLiquidity external function with NatSpec documentation
#116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
removeLiquidityexternal function to theTestAMMContractwith full NatSpec annotations. The function allows users to withdraw liquidity from prediction market pools while ensuring proportional distribution of reserves and protection against slippage.Changes
New Function:
removeLiquidity_marketId— unique identifier for the prediction market._user— address of the liquidity provider removing funds._liquidity— amount of liquidity tokens to burn/remove._amount0Min— minimum acceptable amount of tokenA (slippage protection)._amount1Min— minimum acceptable amount of tokenB (slippage protection).amount0Decreased— tokenA returned to user.amount1Decreased— tokenB returned to user.amount0Collected— mirrorsamount0Decreased(simplified model).amount1Collected— mirrorsamount1Decreased(simplified model).NatSpec Documentation:
@custom:proportional— clarifies liquidity share math.@custom:slippage— explains role of slippage protection.Formatting:
forge fmtfor consistency and readability.Motivation
addLiquidityfunctionality.Next Steps
userLiquiditymapping (if not already included).LiquidityRemovedevent emission with full context (user, marketId, amounts).