drop deprecated pkg_resources #1092
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
remove-deprecated_pkg_resources
branch
3 times, most recently
from
dfe43fc to
e986634
Compare
Each time we run pytest in our GitHub Actions, we get the warning: ```tests/test_mavlogdump.py:9 /home/runner/work/pymavlink/pymavlink/tests/test_mavlogdump.py:9: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81. import pkg_resources ``` Use `here = pathlib.Path(__file__).parent` to replace `pkg_resources.resource_filename(__name__, xxx)`. All modified files are run by pytest in our GitHub Actions.
cclauss
force-pushed
the
remove-deprecated_pkg_resources
branch
from
e986634 to
dbceb85
Compare
amilcarlucas
approved these changes
Jul 14, 2025
|
Nice cleanup |
peterbarker
requested changes
Jul 15, 2025
|
|
||
| import unittest | ||
| import pkg_resources | ||
| from pathlib import Path |
There was a problem hiding this comment.
Suggested change
| from pathlib import Path | |
| import pathlib |
and namespace the creation of the object
| test_filename = "64-fields.xml" | ||
| test_filepath = pkg_resources.resource_filename(__name__, | ||
| test_filename) | ||
| test_filepath = str(here / "64-fields.xml") |
There was a problem hiding this comment.
Is this equivalent to what we did have? ie. this looks like it's trying to take out of an installed package space if that's where you currently are. It's very weird if that's not the case as you wouldn't need to use pkg_resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time we run pytest in our GitHub Actions, we get the warning:
https://setuptools.pypa.io/en/latest/pkg_resources.html
Use
here = pathlib.Path(__file__).parentto replacepkg_resources.resource_filename(__name__, xxx).How is this tested?
All modified files are run by pytest in our GitHub Actions.