TelemetryDashboard: support HEARTBEAT send and signing #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should allow sending the heartbeat without also giving the user the option to set the system and component IDs. I don't mind adding support or sending, but I don't think it should be the default. |
IamPete1
reviewed
Jul 29, 2025
and add cli_test.js
tridge
force-pushed
the
pr-mavlink-update
branch
from
6b72752 to
1fdab91
Compare
|
I incorporated the changes into #267 as well, with the requested fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we could instead have a separate tool if you'd prefer not to support sending HEARTBEAT in the dashboard