build(setup.py): modernize setuptools #723
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the setuptools configuration to address deprecation warnings and improve package data handling. The changes update both the legacy setup.py and modern pyproject.toml configurations to use current best practices.
Key changes:
- Updates setuptools and wheel to specific pinned versions
- Switches from implicit package discovery to explicit configuration
- Enhances package data patterns to include subdirectories with
**/*glob patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Adds explicit package_data configuration with recursive patterns while maintaining backward compatibility |
| pyproject.toml | Pins dependency versions, disables implicit package data inclusion, and updates glob patterns for better file discovery |
setup.py
Outdated
| setup( | ||
| packages=["ardupilot_methodic_configurator"], | ||
| # this is used by bdist | ||
| include_package_data=False, |
There was a problem hiding this comment.
[nitpick] Setting include_package_data=False in setup.py while also setting include-package-data=false in pyproject.toml creates redundant configuration. Consider removing this from setup.py since pyproject.toml is the primary configuration file.
| include_package_data=False, |
Copilot uses AI. Check for mistakes.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
amilcarlucas
force-pushed
the
modernize_setuptools
branch
from
71a9cf1 to
81c3658
Compare
amilcarlucas
force-pushed
the
modernize_setuptools
branch
2 times, most recently
from
aa40e73 to
9f842b7
Compare
And hopefully fix some warnings
amilcarlucas
force-pushed
the
modernize_setuptools
branch
from
9f842b7 to
72c9602
Compare
pyproject.toml replaces it
And hopefully fix some warnings