Motor test backend #700
Merged
Motor test backend #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 files 2 suites 1m 31s ⏱️ For more details on these failures, see this check. Results for commit 064deae. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive motor test GUI for ArduPilot flight controllers, implementing a complete Model-View architecture with robust testing capabilities. The implementation adds motor testing functionality, frame configuration management, battery safety monitoring, and SVG diagram rendering through new GUI components and data models.
- Motor test GUI implementation with safety features and real-time feedback
- Exception-based error handling refactoring in data model with comprehensive validation
- SVG conversion utilities for motor diagrams with multiple backend support
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_data_model_motor_test.py | Updated tests to use exception-based error handling and properties instead of method calls |
| scripts/download_motor_diagrams.py | Added SVG to PNG conversion functionality with multiple backend support |
| pyproject.toml | Added scikit-build and tksvg dependencies for GUI functionality |
| ardupilot_methodic_configurator/frontend_tkinter_motor_test.py | New comprehensive motor test GUI implementation with safety features |
| ardupilot_methodic_configurator/data_model_motor_test.py | Major refactoring to exception-based error handling and property-based API |
| ardupilot_methodic_configurator/backend_flightcontroller.py | Added fetch_param method for parameter verification |
| ardupilot_methodic_configurator/backend_filesystem_program_settings.py | Restructured motor test settings to nested configuration |
| ARCHITECTURE_motor_test.md | Updated documentation to reflect implemented features |
| .vscode/launch.json | Added debug configuration for motor test frontend |
amilcarlucas
force-pushed
the
motor_test_gui
branch
from
f55c184 to
260b790
Compare
amilcarlucas
force-pushed
the
motor_test_gui
branch
2 times, most recently
from
bfe5d7f to
635281e
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
amilcarlucas
force-pushed
the
motor_test_gui
branch
2 times, most recently
from
23dbc48 to
9253df4
Compare
amilcarlucas
force-pushed
the
motor_test_gui
branch
from
9253df4 to
064deae
Compare
It now raises exceptions that the frontend should catch and display to the user. The motor diagrams are all png now, I've given up on svg. They're to hard to render correctly
amilcarlucas
force-pushed
the
motor_test_gui
branch
from
064deae to
09544d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comprehensive motor test business logic for ArduPilot flight controllers, implementing the complete model in a Model-View architecture with robust testing capabilities. The implementation adds motor testing functionality, frame configuration management, battery safety monitoring