Fix graphic pipe connections #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2025 09:51
Renamed Hydro Plant pipe graphics to match their actual direction. (east -> west) Code formatting adjustment.
KiwiHawk
reviewed
Dec 24, 2025
| { | ||
| production_type = "input", | ||
| mirrored_pipe_picture = angelsmods.petrochem.steamcrackerpipepictures1(), | ||
| --pipe_picture = floatationpipepictures(), |
Collaborator
There was a problem hiding this comment.
Should pipe_picture be set here?
Author
There was a problem hiding this comment.
Not in this case, the default view is blank, so it is not shown, but if we flip it then we need to show the mirrored one.
Author
There was a problem hiding this comment.
Because the buildings don't actually rotate, their h/v "mirror" just changes the pipe output ordering, but it does mean it will move a pipe that was not visible before the mirroring.
Also because the buildings don't rotate, we can just use the "other" pipe's graphic without having to actually mirror them.
KiwiHawk
reviewed
Dec 24, 2025
KiwiHawk
reviewed
Dec 24, 2025
angelsrefininggraphics/graphics/entity/filtration-unit/target.png
Outdated
Show resolved
Hide resolved
KiwiHawk
added
Graphics
Angels Refining
added 2 commits
December 23, 2025 20:17
…unit; delete unused target image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses : #1171
Main issue was fixing Filtration building, however, saw that some others from Petrochem had issues as well, took a stab at those.
Due to how the overlay / transparency is working, I can't -quite- get the shadows of the pipe match to the shadows of the Filter building. Tweaked things, but I'm not really an artist here.
There's a few other Petrochem buildings with "floating" Pipe end-caps, I left them as they are not quite as glaring.
Advanced Chem plant will require more artistic abilities that I have (nearly zero).
Edited the Hydro Plant's west facing pipe connection to be "pipe-west1.png", from "pipe-east1.png".
May break if something else calls those, but the current functioning mods didn't. :-)