Rework angel artifacts #1185
Draft
Rework angel artifacts #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2.0 the LuaInventory get_contents function no longer returns a dictionary we can index into with an item name. Use the find_item_stack function instead, which can use a item's name in string form. New: https://lua-api.factorio.com/2.0.72/classes/LuaInventory.html#get_contents Old: https://lua-api.factorio.com/1.1.110/classes/LuaInventory.html#get_contents
This means that technology prerequisites are actually respected now. Though admittedly - thats not an issue in any realistic playthrough, it only came up when I spawned in behemoths for testing. It also has the added bonus of popping up the research in chat when completed, which is nice :)
These are mostly just me messing around. Someone with proper graphics skills please help :o
Depending on present mods, either the artifacts added by Bob's Enemies or the ones added by Angel's Exploration are used. This fixes the check also checking for bobsplates. That mod is only relevant for adding the tier 4 gem to the recipe, not for picking what item names to use for artifacts. Note: This can probably be cleaned up by having a saner mod cross-integration approach with mods agreeing upon what gets generated based on the settings stage, instead of checking the results of the data stage and running all of this logic in the data-update stage.
Author
Collaborator
|
This PR now has conflicts because of 381f85e (sorry!). I believe bioprocessing is working fine now with Bob's. This PR should probably be constrained to modifying Angel's Exploration mod. |
KiwiHawk
reviewed
Nov 18, 2025
| }, | ||
| research_trigger = { | ||
| type = "scripted", | ||
| trigger_description = "Locate this artifact in your fight against the biters!", |
Collaborator
There was a problem hiding this comment.
Strings should be in the locale files. Makes them possible to translate
Author
There was a problem hiding this comment.
Will move, wasn't specifically aware of that 👍
KiwiHawk
reviewed
Nov 18, 2025
| }, | ||
| research_trigger = { | ||
| type = "scripted", | ||
| trigger_description = "Locate this artifact in your fight against the biters!", |
Collaborator
There was a problem hiding this comment.
Also means it won't be repeated
Author
There was a problem hiding this comment.
It might also be nice to have a per-color text to hint at where this drops from 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Right now this PR is on top of the
fix_build_script_permissionsbranch of #1184. This is just due to me being too lazy to carry around an extra commit and/or uncommitted change on top of this WIP workI also opened this discord discussion thread for this topic:
https://discord.com/channels/546453368730681400/1432472088316215406/
Overview
This PR tackles the alien artifacts that are part of
angelsbioprocessingandangelsexploration. The former also has integrations with Bob's Enemies (bobenemies) and Bob's Metals, Chemicals and Intermediates mod (bobplates)Integration
Bob's Mods
If bobenemies is present and does add artifacts, angelsbioprocessing will add recipes & technologies to craft small artifacts.
If bobplates is also present, that recipe will include a tier 4 gem (e.g.
item:bob-ruby-4aka a Cut Ruby for red artifacts).Angel's Exploration
Colored alien artifacts (similar to what bobenemies does) are also added by Angel's Exploration.
My current thoughts are to have angelsbioprocessing generate the synthetic artifact recipes for this one too. I'll admit - I've lost track of how this worked (or didnt?) before I started tinkering.
Remaining tasks
angelsbioprocessingandangelsexploration