Tweaks: Apply "hide (mini)-follow buttons" to new post header

[marcustyphoon]

Description

This updates the "hide mini-follow buttons" tweak so the feature will apply to the new post header. (Okay, they're not really "mini" buttons anymore; this also renames the tweak.)

There's no distinguishing CSS for follow buttons, so I made really sure we don't hit the wrong ones by checking the post data.

At time of writing, this code is for a UI element that doesn't exist. We could be cheeky and merge it in advance in case the feature ever does exist, of course.

Testing steps

• Confirm that the mini-follow buttons on posts are still hidden by the feature.
• With the relevant flag, confirm that the large follow buttons in the primary header on original posts are hidden by the feature.
• With the relevant flag, confirm that the large follow buttons in the first trail item on reblogged posts are hidden by the feature.
• With the relevant flag, confirm that the large buttons in the primary header which do not say "follow" are not hidden by the feature.

Test the feature in each UI language.

[marcustyphoon]

Probably won't be able to test this this weekend, but if I recall correctly it's done and works?

(Obviously ignore this if the thing it's supposed to apply to is at all likely to change)

[AprilSylph]

To be honest I think we should retire this tweak when the new UI launches. The main reason they're so egregious in the current UI (in my eyes) is their repetition, being present for every possible entity... with the move to a maximum of one per post, that problem is (FINALLY) solved in Tumblr proper.

[marcustyphoon]

I think that's a fair argument, and also one I... well, okay, I'm not going to say I disagree necessarily :D I haven't been using the new UI regularly, so all I have is first impressions, but those new buttons sure are big.

[AprilSylph]

We can keep this PR open and revisit it after launch. Whether or not we get bug reports / feature requests to please hide the big follow buttons will be interesting to see...

[marcustyphoon]

Yeah, agreed.

My immediate thought was "I'll put $20 on 'immediate vocal outcry in the tags' in a heartbeat," but that very evidently does not translate to Github issues, so the terms of the bet would have to be quite specific :D

[marcustyphoon]

Uuuuuugh fuck it I'm probably just going to replace the timelineObject processing in this with the translate utility. It's too complicated to handle all of the possible edge cases with how trail items could plausibly use internal data when all we want is "hide a button that says 'follow.'"

I would feel more comfortable doing this if we had a more exhaustive version of the translation dictionary; French has multiple entries for "follow" (google translate translates one of them to "subscribe").

• do this
• test in every language

[marcustyphoon]

For the sake of making it official, my opinion on the follow buttons if the current code is the final code is "but why though."