Skip to content

Upgrade gosling.js to 0.17.0#129

Open
jakubsob wants to merge 4 commits into
develfrom
upgrade-react
Open

Upgrade gosling.js to 0.17.0#129
jakubsob wants to merge 4 commits into
develfrom
upgrade-react

Conversation

@jakubsob

Copy link
Copy Markdown

Have you read the Contributing Guidelines?

Description

  • Upgraded gosling.js to 0.17.0
  • Upgraded the rest of JS dependencies to latest (compatible) versions.

Important

  • Remove "Install shiny.react with React 18.3.1" step from CI before merging.
  • Bump shiny.react dependency in DESCRIPTION to >= 0.4.0

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@jakubsob
jakubsob marked this pull request as ready for review May 15, 2024 13:15
@jakubsob
jakubsob requested a review from jakubnowicki May 15, 2024 13:15
@jakubsob
jakubsob changed the base branch from main to devel May 16, 2024 07:16

@jakubnowicki jakubnowicki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the size limit in Bioconductor, inst/www directory should be added here: https://github.com/Appsilon/shiny.gosling.js
This repo is served as CDN: https://github.com/Appsilon/shiny.gosling/blob/main/R/components.R#L9

Comment thread DESCRIPTION
Title: A Grammar-based Toolkit for Scalable and Interactive Genomics Data Visualization for R and Shiny
Version: 1.0.0
Title: A Grammar-Based Toolkit for Scalable and Interactive Genomics Data Visualization for R and Shiny
Version: 2.0.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 1.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants