Refactor login logic and add unique keys to Editor components#1609
Open
cannarocks wants to merge 4 commits into
Open
Refactor login logic and add unique keys to Editor components#1609cannarocks wants to merge 4 commits into
cannarocks wants to merge 4 commits into
Conversation
Update cognito may
fix: add unique keys to Editor components for bug details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily refactors and simplifies the
LoginPageauthentication logic, removing the legacy WordPress login fallback and related error handling. It also introduces minor improvements to the bug detail description component to ensure correct re-rendering of theEditorcomponent.Authentication flow simplification:
LoginPage, so authentication now relies solely on Cognito. All related logic and error handling for WordPress login have been deleted.showGenericErrorToastfunction, as generic error handling for the legacy login is no longer needed.Component improvements:
Editorcomponents inBugDetail/Description.tsxto include akeyprop based on their respective content (step_by_step,expected_result,current_result). This ensures the editor re-renders properly when the content changes.Code organization:
BugDetail/Description.tsxandLoginPage/index.tsxfor clarity and to remove unused dependencies (such asWPAPIandWrappedText). [1] [2]