Enhance JoinPage routing and improve error handling for submissions#1593
Merged
Conversation
Enhance JoinPage routing and improve HubSpot submission error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user experience and error handling in the join flow. The main changes include enhancing routing to preserve search parameters during redirects and improving logging for HubSpot API errors.
Routing improvements:
DefaultRedirectcomponent insrc/pages/JoinPage/index.tsxto ensure that when users are redirected to the signup page, any search parameters in the URL are preserved. This helps maintain important context.JoinPageto use the newDefaultRedirectcomponent instead of a basic redirect, further ensuring search parameters are not lost.Error handling improvements:
console.errorlogging (with ESLint disables) for both HubSpot API errors and general exceptions insendToHubspot, making debugging easier.