Add in New Surface Rules & Conditions#70
Open
voidsong-dragonfly wants to merge 13 commits intoApollounknowndev:1.21from
Open
Add in New Surface Rules & Conditions#70voidsong-dragonfly wants to merge 13 commits intoApollounknowndev:1.21from
voidsong-dragonfly wants to merge 13 commits intoApollounknowndev:1.21from
Conversation
- TransientMergedRuleSource now uses the default implementation of `SequenceRule` - Code is deduplicated from Vanilla - Mods such as TerraBlenderFix should work more effectively as their mixins into `SequenceRule` will now run as intended, rather than only sometimes
voidsong-dragonfly
force-pushed
the
feature/npsurfacerules
branch
from
93eb0dd to
32c4e51
Compare
- The noise cache had no noticeable performance impact, nor did the noise analysis rules - Thus, we can reasonably remove the noise cache without affecting performance
- Cave depth rule no longer scans for caves when the underground above it is entirely solid - Windswept terrain will no longer take an extra second to load into a 32-chunk render distance world just to run the cave depth rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in new surface rules from Natural Philosophy, intended for others to be able to use what I've developed.
It adds multiple conditions and multiple rules; documentation in human-readable format can be found here.
Examples using the new surface rules are available upon request or can be found in Natural Philosophy on the currently in-development branch.
Full Javadocs are included for complex code (conditions and rules), however condition & rule sources were left out due to the simplicity of their implementation compared to rules and conditions.