Skip to content

Defensive Measures #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SmushyTaco merged 1 commit into from
Dec 6, 2025
Merged

Defensive Measures #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/kotlin/me/apollointhehouse/raywire/internal/EventManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import me.apollointhehouse.raywire.api.Event
import me.apollointhehouse.raywire.api.EventHandler
import java.lang.ref.WeakReference
import java.lang.reflect.Method
import java.lang.reflect.Modifier
import java.util.WeakHashMap
import kotlin.collections.ArrayDeque

Expand All @@ -40,7 +41,13 @@ internal class EventManager : Bus {

val methods = allDeclaredMethods(klass)
.filter { it.isValid() }
.onEach { it.isAccessible = true }
.onEach {
try {
it.isAccessible = true
} catch (e: Exception) {
LOGGER.error("Failed to make ${it.name} accessible.", e)
}
}
.toList()

for (method in methods) {
Expand Down Expand Up @@ -108,6 +115,7 @@ internal class EventManager : Bus {
*/
private fun Method.isValid(): Boolean {
if (!isAnnotationPresent(EventHandler::class.java)) return false
if (Modifier.isStatic(modifiers)) return false
if (returnType != Void.TYPE) return false
if (parameterCount != 1) return false

Expand Down
Loading