Fix input validation, event payload consistency, and pagination semantics - #529
Open
Lakes41 wants to merge 1 commit into
Open
Fix input validation, event payload consistency, and pagination semantics#529Lakes41 wants to merge 1 commit into
Lakes41 wants to merge 1 commit into
Conversation
…tics - Add MTTR input range validation: reject mttr_minutes > 525,600 (365 days) with InvalidInput error instead of misleading InvalidPenaltyAmount - Add config_version_hash and recorded_at to sla_calc event payload for config generation attribution consistency with set_int and dup_input events - Fix pagination has_more semantics: return false when limit == 0 to align with "empty page as end-of-history signal" policy - Update documentation for input constraints, event schemas, and pagination policy - Add comprehensive test coverage for limit == 0 pagination edge cases
|
@Lakes41 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #515
closes #516
closes #517
closes #518
Description
This PR fixes three issues affecting input validation, event payload consistency, and pagination semantics to improve error clarity, enable config generation attribution, and align implementation with documented policies.
Type of Change
Related Issues
Relates to version discovery interfaces, event payload consistency, and pagination policy issues
Changes Made
Testing
Describe the testing performed to validate these changes:
Checklist
Screenshots (if applicable)
Add screenshots or logs if applicable.