Repository navigation
fix(ci): keep Bun jobs from replacing the shared runtime - #77
Conversation
pi-web-access also registers web_search, so pi -e . failed to start with a tool conflict. Rename this repo tool to agentic_utilities_web_search, per the globally specific naming rule in rules/extensions.md.
|
1 finding · reviewed 🟠
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed all four changed files, including runtime selection, commit-hook behavior, and search-tool registration and references.
- Job-scoped Bun: The check job downloads Bun
1.3.7intorunner.tempand selects it throughGITHUB_PATH, without installing over the shared home-directory runtime. Existing verification steps and the secret-scan dependency remain intact. - Commit hook: Staged linting, typechecking, and tests now use Bun while preserving both secret scans and fail-fast behavior.
- Search-tool namespace:
agentic_utilities_web_searchavoids the existingweb_searchcollision; the catalog matches the registration, and no repository callers retain the old name.
Validation passed for the exact installer, lint, typecheck, tests, package dry-run, collision-aware registration smoke test, and actual Pi RPC startup. The full local check returned Tool 'shell' timed out after 120000ms; the PR's CI check and secret-scan jobs passed.
gpt-6.1-sol ｜ 𝕏
1 participant
Problem
The check job replaces the shared Bun executable used by other work.
The commit hook uses a different package runner from the project scripts.
The package cannot start when another extension also registers web_search.
Change
Keep the check job's runtime inside its temporary directory and give the repository search tool a unique name.
Proof
Pi startup uses its documented RPC mode and closes input after twelve seconds.
No extension is disabled, and no model prompt is sent.
The check job still depends on the secret scan job.
The separate PR body workflow keeps its existing setup action.
This change does not claim isolation for every workflow.
Both hosted CI runs passed on 0140aa6. Pullfrog approved this exact head.
The check job used job-owned Bun 1.3.7.
The Pullfrog approval passed on the same commit.
Review
The prior CI and hook review found no Act On items.
The fresh combined review found no Act On items on 9d9e5db.
Real tool registration, Pi startup and the three-commit secret scan passed.
Main then advanced. A normal merge created 0140aa6, and the repeated checks and fresh review passed.
All four changed files are byte-identical to the reviewed version. All 24 base-only files match current main.
Merge danger
Door: two-way. Revert the affected commits to restore the previous behavior.
Blast radius: low. The check job and local commit hook keep their existing verification commands.
The search tool name changes for package users. No repository prompt, skill or caller uses the old name.
The actual package starts with both search extensions loaded.
No shared executable, profile or extension configuration changes during the proof.
Changes made by GPT-6.1 Sol and Claude Opus 5.5 via T3 Code