Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty: adjust report for NotEmpty+len cases #189

Merged
merged 4 commits into from
Oct 3, 2024
Merged

empty: adjust report for NotEmpty+len cases #189

merged 4 commits into from
Oct 3, 2024

Conversation

Antonboom
Copy link
Owner

Closes #149

@coveralls
Copy link

coveralls commented Oct 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11167657197

Details

  • 106 of 108 (98.15%) changed or added relevant lines in 23 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 93.805%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_diagnostic.go 33 35 94.29%
Totals Coverage Status
Change from base Build 11158782151: -0.06%
Covered Lines: 2453
Relevant Lines: 2615
💛 - Coveralls

@Antonboom Antonboom changed the title Fixes/empty empty: adjust report for NotEmpty+len cases Oct 3, 2024
@Antonboom Antonboom merged commit 44419da into master Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty: report special message for len and string-cast cases
2 participants
@Antonboom @coveralls