useless-assert: add NotElementsMatch and NotErrorAs (#220)

* Upgrade testdata to v1.10.0 of testify * self-review fixes * issue 213 debug * useless-assert: add NotElementsMatch and NotErrorAs
Antonboom · Feb 10, 2025 · a4092df · a4092df
1 parent 6b7bd9b
commit a4092df
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 0 deletions.
diff --git a/analyzer/testdata/src/checkers-default/useless-assert/useless_assert_test.go b/analyzer/testdata/src/checkers-default/useless-assert/useless_assert_test.go
diff --git a/analyzer/testdata/src/debug/error_as_test.go b/analyzer/testdata/src/debug/error_as_test.go
@@ -0,0 +1,22 @@
+package debug
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestErrorAsGenericTarget(t *testing.T) {
+	var err error = new(os.PathError)
+
+	errorAs[*os.PathError]()(t, err)
+	errorAs[*os.LinkError]()(t, err)
+}
+
+func errorAs[T error]() require.ErrorAssertionFunc {
+	return func(t require.TestingT, err error, msgAndArgs ...interface{}) {
+		var target T
+		require.ErrorAs(t, err, &target, msgAndArgs...)
+	}
+}
diff --git a/internal/checkers/useless_assert.go b/internal/checkers/useless_assert.go
@@ -127,8 +127,10 @@ func (checker UselessAssert) checkSameVars(pass *analysis.Pass, call *CallMeta)
 		"JSONEq",
 		"Less",
 		"LessOrEqual",
+		"NotElementsMatch",
 		"NotEqual",
 		"NotEqualValues",
+		"NotErrorAs",
 		"NotErrorIs",
 		"NotRegexp",
 		"NotSame",

diff --git a/internal/testgen/gen_useless_assert.go b/internal/testgen/gen_useless_assert.go
@@ -41,8 +41,10 @@ func (g UselessAssertTestsGenerator) TemplateData() any {
 		"JSONEq":              "str, str",
 		"Less":                "value, value",
 		"LessOrEqual":         "value, value",
+		"NotElementsMatch":    "value, value",
 		"NotEqual":            "value, value",
 		"NotEqualValues":      "value, value",
+		"NotErrorAs":          "err, err",
 		"NotErrorIs":          "err, err",
 		"NotRegexp":           "value, value",
 		"NotSame":             "value, value",