Merge pull request #4 from Antonboom/feat/analyze-all-files

Do not ignore not test files

.golangci.yml

@@ -12,6 +12,9 @@ issues:
       linters: [ "revive" ]
       text: "exported"
 
+    - path: "internal/testgen"
+      linters: [ "forbidigo", "gochecknoinits" ] # Internal test generation tool.
+
     - path: "internal"
       linters: [ "revive" ]
       text: "exported (method|const)"
@@ -33,6 +36,9 @@ linters-settings:
 
   forbidigo:
     forbid:
+      - p: panic
+        msg: Please, don't panic
+
       - p: types\.ExprString
         msg: Please, use analysisutil.NodeBytes/NodeString instead
 

analyzer/analyzer.go

@@ -55,9 +55,6 @@ type testifyLint struct {
 func (tl *testifyLint) run(pass *analysis.Pass) (any, error) {
 	filesToAnalysis := make([]*ast.File, 0, len(pass.Files))
 	for _, f := range pass.Files {
-		if !analysisutil.IsTestFile(pass.Fset, f) {
-			continue
-		}
 		if !analysisutil.Imports(f, testify.AssertPkgPath, testify.RequirePkgPath, testify.SuitePkgPath) {
 			continue
 		}

analyzer/analyzer_test.go

@@ -33,8 +33,8 @@ func TestTestifyLint(t *testing.T) {
 			},
 		},
 		{dir: "ginkgo"},
-		{dir: "not-test-file"},    // We ignores regular files.
-		{dir: "not-true-testify"}, // We ignores stretchr/testify's forks.
+		{dir: "not-test-file"},    // By default, linter checks regular files too.
+		{dir: "not-true-testify"}, // Linter ignores stretchr/testify's forks.
 		{dir: "pkg-alias"},
 		{
 			dir: "suite-require-extra-assert-call",

analyzer/testdata/src/not-test-file/service_test.go

@@ -0,0 +1,10 @@
+package service
+
+import (
+	"testing"
+)
+
+func TestService(t *testing.T) {
+	var predicate bool
+	assertTrue(t, predicate)
+}

analyzer/testdata/src/not-test-file/file_test.go → analyzer/testdata/src/not-test-file/test_helpers.go

@@ -1,13 +1,13 @@
-package main
+package service
 
 import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 )
 
-func TestNotFake(t *testing.T) {
-	var predicate bool
+func assertTrue(t *testing.T, predicate bool) {
+	t.Helper()
 
 	assert.Equal(t, true, predicate)                                   // want "bool-compare: use assert\\.True"
 	assert.Equalf(t, true, predicate, "msg with args %d %s", 42, "42") // want "bool-compare: use assert\\.True"

analyzer/testdata/src/not-test-file/file_test.go.golden → analyzer/testdata/src/not-test-file/test_helpers.go.golden

@@ -1,13 +1,13 @@
-package main
+package service
 
 import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 )
 
-func TestNotFake(t *testing.T) {
-	var predicate bool
+func assertTrue(t *testing.T, predicate bool) {
+	t.Helper()
 
 	assert.True(t, predicate)                                   // want "bool-compare: use assert\\.True"
 	assert.Truef(t, predicate, "msg with args %d %s", 42, "42") // want "bool-compare: use assert\\.True"

internal/analysisutil/file.go

@@ -2,18 +2,9 @@ package analysisutil
 
 import (
 	"go/ast"
-	"go/token"
 	"strconv"
-	"strings"
 )
 
-// IsTestFile returns true if the file from the file set has the `_test.go` suffix.
-// If the file does not belong to the set, then the function will return false.
-func IsTestFile(fset *token.FileSet, file *ast.File) bool {
-	fname := fset.Position(file.Pos()).Filename
-	return strings.HasSuffix(fname, "_test.go")
-}
-
 // Imports tells if the file imports at least one of the packages.
 // If no packages provided then function returns false.
 func Imports(file *ast.File, pkgs ...string) bool {

internal/analysisutil/file_test.go

@@ -8,61 +8,6 @@ import (
 	"github.com/Antonboom/testifylint/internal/analysisutil"
 )
 
-func TestIsTestFile(t *testing.T) {
-	cases := []struct {
-		filename   string
-		fileSrc    string
-		isTestFile bool
-	}{
-		{
-			filename:   "service.go",
-			fileSrc:    "package service",
-			isTestFile: false,
-		},
-		{
-			filename:   "service_unix.go",
-			fileSrc:    "package service",
-			isTestFile: false,
-		},
-		{
-			filename:   "service_test.go",
-			fileSrc:    "package service",
-			isTestFile: true,
-		},
-		{
-			filename:   "service_test.go",
-			fileSrc:    "package service_test",
-			isTestFile: true,
-		},
-	}
-
-	for _, tt := range cases {
-		t.Run("", func(t *testing.T) {
-			fset := token.NewFileSet()
-
-			file, err := parser.ParseFile(fset, tt.filename, tt.fileSrc, parser.PackageClauseOnly)
-			if err != nil {
-				t.Fatal(err)
-			}
-
-			if tt.isTestFile != analysisutil.IsTestFile(fset, file) {
-				t.FailNow()
-			}
-		})
-	}
-}
-
-func TestIsTestFile_FileIsNotInFileSet(t *testing.T) {
-	file, err := parser.ParseFile(token.NewFileSet(), "service_test.go", "package service_test", parser.PackageClauseOnly)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	if analysisutil.IsTestFile(token.NewFileSet(), file) {
-		t.FailNow()
-	}
-}
-
 func TestImports(t *testing.T) {
 	fset := token.NewFileSet()
 

internal/checkers/bool_compare.go

@@ -209,7 +209,7 @@ func xor(a, b bool) bool {
 // anyVal returns the first value[i] for which bools[i] is true.
 func anyVal[T any](bools []bool, vals ...T) (T, bool) {
 	if len(bools) != len(vals) {
-		panic("inconsistent usage of valOr")
+		panic("inconsistent usage of valOr") //nolint:forbidigo // Does not depend on the code being analyzed.
 	}
 
 	for i, b := range bools {

internal/config/config.go

@@ -9,6 +9,7 @@ import (
 // NewDefault builds default testifylint config.
 func NewDefault() Config {
 	return Config{
+		EnableAll:       false,
 		EnabledCheckers: checkers.EnabledByDefault(),
 		ExpectedActual: ExpectedActualConfig{
 			ExpVarPattern: RegexpValue{checkers.DefaultExpectedVarPattern},

internal/config/config_test.go

@@ -12,12 +12,19 @@ import (
 
 func TestNewDefault(t *testing.T) {
 	cfg := config.NewDefault()
+
+	if cfg.EnableAll {
+		t.Fatal()
+	}
 	if !slices.Equal(cfg.EnabledCheckers, checkers.EnabledByDefault()) {
 		t.Fatal()
 	}
 	if cfg.ExpectedActual.ExpVarPattern.String() != checkers.DefaultExpectedVarPattern.String() {
 		t.Fatal()
 	}
+	if cfg.SuiteExtraAssertCall.Mode != checkers.SuiteExtraAssertCallModeRemove {
+		t.Fatal()
+	}
 }
 
 func TestBindToFlags(t *testing.T) {

internal/testgen/main.go

@@ -35,7 +35,7 @@ var checkerTestsGenerators = []CheckerTestsGenerator{
 	SuiteTHelperTestsGenerator{},
 }
 
-func init() { //nolint:gochecknoinits // Internal test generation tool.
+func init() {
 	genForChecker := make(map[string]struct{}, len(checkerTestsGenerators))
 	for _, g := range checkerTestsGenerators {
 		name := g.Checker().Name()