Skip to content

Conversation

@mikalv
Copy link
Contributor

@mikalv mikalv commented May 8, 2018

Seems better to upgrade source while at it. Then we can also get rid of some old trash :)

@mikalv mikalv requested a review from oyvkva May 8, 2018 18:02
@mikalv mikalv changed the base branch from master to ltc16 May 8, 2018 18:10
mikalv and others added 17 commits May 8, 2018 20:17
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
@mikalv mikalv self-assigned this May 9, 2018
@mikalv mikalv requested a review from yhaenggi May 9, 2018 16:50
mikalv and others added 26 commits May 13, 2018 19:57
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
Signed-off-by: Mikal Villa <[email protected]>
@Choms
Copy link

Choms commented Jul 5, 2019

As a note regarding this and your other PR (and I know both have been open for a long time), any changes/PRs should be atomic and small, this PR is just too big for anyone to review (even github won’t show all the changes) plus the fact that unit tests doesn’t work and there is no way of knowing the stability of the changes means they will never get merged

Instead you should split functional additions, file rebranding and documentation changes on their own smaller PRs

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants